Use shared constant for hours per year#764
Open
Alb3e3 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HOURS_PER_YEARto the shared workflow constants8760/8760.0year-hour literals in workflow scripts and rulesCloses #763.
Verification
python3 -m py_compile workflow/scripts/constants.py workflow/scripts/eulp.py workflow/scripts/add_extra_components.py workflow/scripts/_helpers.py workflow/scripts/prepare_network.py workflow/scripts/solve_network.py workflow/scripts/build_demand.py workflow/scripts/build_cost_data.py workflow/scripts/test/test_constants.pyuvx ruff check workflow/scripts/constants.py workflow/scripts/eulp.py workflow/scripts/add_extra_components.py workflow/scripts/_helpers.py workflow/scripts/prepare_network.py workflow/scripts/solve_network.py workflow/scripts/build_demand.py workflow/scripts/build_cost_data.py workflow/scripts/test/test_constants.pyuvx --from pytest pytest --noconftest workflow/scripts/test/test_constants.py -qNote: I attempted the project-managed pytest run with
uv run --extra dev pytest workflow/scripts/test/test_constants.py -q, but local dependency sync failed while buildingdatrie==0.8.2from Snakemake on this machine before tests could start. The isolated static test above avoids the heavyweight model dependencies and passes.